Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'How to add a new video bidder adaptor' #170

Merged
merged 3 commits into from
Feb 9, 2017
Merged

Add 'How to add a new video bidder adaptor' #170

merged 3 commits into from
Feb 9, 2017

Conversation

rmloveland
Copy link
Contributor

Also update 'How to Add a New Bidder Adaptor' as follows:

  • Add links to the new page

  • Remove most of the video-related content in favor of linking to the
    new video-specific page

Add 'How to add a new video bidder adaptor'
e6ebf91 
Also update 'How to Add a New Bidder Adaptor' as follows:

- Add links to the new page

- Remove most of the video-related content in favor of linking to the
  new video-specific page
@rmloveland
Copy link
Contributor Author

@mjacobsonny mind taking a look at this?

Scope is:

  • I broke out 'How to add a new video bidder adaptor' into a separate page (This is added missing 'a' #1 from your AC on RAD-1374)

  • The new page makes it clear (I hope!) that you have to support your own VAST URL (Fixing amazon wrong parameter name #2 from your AC)

  • Made some updates to the existing 'How to add a new bidder adaptor' page, mostly to add links to the video-specific docs

In addition:

  • Going to wait to start the 'how to add video support to an existing display adaptor' (Adding casale params doc #3 from AC) until this is reviewed to make sure I'm on the right track. As soon as this gets the thumbs up I'll merge it and start on that.

Rich Loveland added 2 commits February 7, 2017 13:45
Clarify description of how bid.params is defined
2cc1b76
Revise to add more video-specific examples/code
69a7c24 
Specifically:

- Clarify `bid.params` description
- Show an AST video bid request object
- Break Step 5, "Register bid responses" into smaller chunks
- Clarify adding video info to bid response
- Smaller copy edits sprinkled throughout
@rmloveland rmloveland merged commit 116e498 into master Feb 9, 2017
@rmloveland rmloveland deleted the RAD-1374 branch February 9, 2017 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rmloveland